Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Ability to set to set number of announcements to be listed

Description

It might be good to have the configuration box in announcement portlet take the no of announcements to be displayed in the page.The blog portlet has this in the form of "Maximum Items to Display" were we can specify how many entries should be displayed within the portlet window.
This might be useful if the entries are growing in size.

Attachments

1

Activity

Show:

Koor GaiAugust 1, 2012 at 5:44 PM

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x CE GIT ID: 8d1a449da2d20216b219d3cf91539cc2d6ec78e4.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: f2a350129a60b71def82d82513bcc63ca893422b.

Before improvement went in, User has no option to set number of announcemnets to be displayed.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.1 CE GIT ID: fe708510b1566583870a6be892d86f1761a1e64b.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 02653b03e6aa0ecfe810ee4cffc0ad9f26e3affd.

Now User has ability to set number of announcements to be displayed in announcement entires.

Juan FernándezMay 30, 2012 at 12:21 AM

Hi Drew!
I have sent your PR to Brian after doing some changes. I recommend to see my changes here (https://github.com/brianchandotcom/liferay-portal/pull/5463). Basically I removed the empty ConfigurationAction and set it to the default
Thanks, man! Keep them coming!
Juan Fernández

Juan FernándezMay 29, 2012 at 8:48 AM

Wow! That was fast!
Cool contribution.
I've seen the blogs configuration.jsp (ouch! Ugly!), and I totally agree that for consistency sake we should update it to be consistent with our changes.
Can you please open a ticket for that other improvement and send me a PR too?
Thanks, buddy!

Drew BlessingMay 29, 2012 at 8:43 AM

Juan,

Thanks for taking a look at this. I made the proposed changes and submitted the pull request.

I completely agree that this implementation is a better approach than the original one. As a note, the original implementation I modeled after the Blog configuration.jsp. Should that be improved similar to this? I can submit an improvement issue and would be happy to contribute that as well.

Juan FernándezMay 28, 2012 at 6:30 AM

Hi Drew!
Sorry for the delay. First of all thanks for your contribution.
Regarding the alerts portlet... we shouldn't limit the number of alerts, as they may be really important.
Regarding your implementation, I think it is quite clean. The only thing I would change is the aui:select in configuration.jsp, using the pattern used in journal see portal.properties - journal.articles.page.delta.values=5,10,25,50,100 - and journal_Articles/configuration.jsp)

Apart from that, I think the improvement is quite cool. Why don't you update it and send me a pull request (@juanferrub)?
Thanks, man!
Juan

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Branch Version/s

6.1.x

Backported to Branch

Committed

Epic/Theme

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created December 18, 2008 at 7:09 PM
Updated June 23, 2023 at 8:50 PM
Resolved August 1, 2012 at 5:51 PM