Workflow can be saved without configuring Condition Node

Description

Workflow can be saved without configuring Condition Node.

Steps to Reproduce:

  1. Deploy kaleo-web, kaleo-designer, kaleo-forms portlet

  2. Add Kaleo Forms portlet to the page

  3. Click Process > Add

  4. Click Select for the Entry Definition

    • Click "To Do"

  5. Click Select for Workflow

    • Click Add Definition

    • Title: "Test Workflow"

    • Click Add Draft

  6. Drag and Drop Condition Node

  7. Drag connector from Condition Node to End Node

  8. Click Save Draft

  9. Click Publish
    User is able to publish the workflow without a valid Condition Node

Environment

Tomcat 7 + MySQL 5. Portal 6.1.x GIT ID: fc6ad491f67e8a46168506767421b9d1ede7c6ed. Plugins 6.1.x GIT ID: ab23af046662d8b6c5eca5771678b34fa52457c1e.

Attachments

1

Activity

Show:

Catherine LuiJuly 23, 2012 at 3:22 PM

PASSED manual testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 3a0ff22feb0ded7a56bd193b4f584f3e404455e5.
Plugins 6.1.x EE GIT ID: 7cf6fcc3040e9642774f10d955688478922eb333.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 1f6688279671eb369a3d7f96005f5d0e6c81926f.
Plugins 6.1.x EE GIT ID: 027322798e3aa00ea4326aece954edb9f2067337.
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 67b26603b2119d49ee98e075c281a2a5e275b98a.
Plugins 6.1.x EE GIT ID: c572d321f11acd4271629c515bebba21b250c3ab.

Marcellus TavaresJuly 14, 2012 at 3:16 PM
Edited

Hi Greg, I just added a new validation rule to kaleo () in order to prevent the case where multiple end nodes (without transitions) are defined in the workflow definition.

The rule should be enough to invalidate definition like the one described in this ticket.

Thanks

Gregory AmersonJuly 13, 2012 at 1:36 AM
Edited

Hey guys,

Just discussed this ticket with Tammy. She showed me how to replicate and I looked at the code that the kaleo designer creates by using the above steps. The code that is generated is valid based on the workflow validator rules (schema + transition target node checks). So I believe the kaleo designer is acting correctly.

My recommendation would be to update the test plan where it was expecting to see an error. I believe the behavior that is now seen (no error) is correct.

Jeffrey YangMay 30, 2012 at 5:44 PM

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 3a0ff22feb0ded7a56bd193b4f584f3e404455e5.
Plugins 6.1 EE GIT ID: 7cf6fcc3040e9642774f10d955688478922eb333.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Fix Priority

4

Components

Affects versions

Priority

Zendesk Support

Created May 8, 2012 at 8:49 AM
Updated June 24, 2023 at 3:48 PM
Resolved July 14, 2012 at 3:17 PM