PanelApp needs to override getLabel(locale) to be shown properly in 7.4

Fix Priority

4

Components

Affects versions

Git Pull Request

Description

PanelApp, as documented on blade-samples, displays its localization key instead of the name in the panel (see screenshot) 

Until 7.3, it was not necessary to override getLabel(Locale locale) - with 7.4 it's necessary.

This seems to be related to the changed implementation of BasePanelApp.getLabel(Locale), which also looks like something else was intended:

Master, as of today when I file this issue:

(e.g.: If the first call to LanguageUtil.get failed, let's log an exception and call it again to reveal the result)

My best guess is that either the first or the second LanguageUtil.get call should have survived from the old implementation in 7.3, e.g.

The old implementation actually still would work. As of 7.4, translations are centralized, so they're loaded from a global module - but not for custom PanelApp implementations. It makes sense to change the order of lookups, but not to eliminate the local lookup and try the failing global one twice.

 

Attachments

4

Activity

Show:

Thiago Moreira February 11, 2022 at 12:06 PM

I made the adjustments on my Language.properties and it is working now. Thanks

Olaf Kock February 11, 2022 at 9:55 AM
Edited

I've also tested on U7 right now and can confirm that it works as expected

Victor LR February 11, 2022 at 9:32 AM
Edited

 In my testing this issue is fixed on U7.

See steps in comment above. I also tested with "PanelCategoryKeys.SITE_ADMINISTRATION_BUILD" to match the screenshot in the description.

Attached my sample portlet and screenshot to the ticket

If there is still a further issue, could you provide steps to reproduce?

Thiago Moreira February 11, 2022 at 7:43 AM

Hey , I just tested U7 and it isn't there. Same problem pop up.
Maybe it will be add to U8? Is there a way to "ask" to add this to the new Update?

Thiago Moreira February 9, 2022 at 1:32 PM

Great, thanks!

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Last Working Version

Fix Pack Versions

Zendesk Support

Created January 26, 2022 at 8:43 AM
Updated April 24, 2024 at 9:32 AM
Resolved January 31, 2022 at 4:16 AM