ant fast-deploy does not work with jspf
Description
Attachments
Activity

Timothy HsuApril 27, 2012 at 6:16 PM
PASSED Manual Testing following the steps in the description.
Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x CE GIT ID: de5370eec93d963c2a15cc09a3f388d228a84198.
Changes in view_images.jspf do not display in Media Gallery portlet.
Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x CE GIT ID: fd5c09985cbdc468be2c02fa62ac87a4d0e8f4ba.
Changes in view_images.jspf display in Media Gallery portlet.

Sharry ShiMarch 12, 2012 at 11:40 PM
PASSED Manual Testing following the steps in the description.
Reproduced on:
Tomcat 7.0 + MySQL 5. 6.1.x.EE GIT ID: 138875155d3ac83581b2c33edafe35d0b3532e49.
The changes in view_images.jspf file do nothing.
Fixed on:
Tomcat 7.0 + MySQL 5. 6.1.x.EE GIT ID: f1ec1510962651d57317b3f74eb841e801e6c279.
Tomcat 7.0 + MySQL 5. 6.2.x GIT ID: 8bc08bc9434a7a98e554722c706c66ca8e578f67.
Changes in view_images.jspf file work well.

Michael SaechangMarch 12, 2012 at 11:01 AM
Committed on:
6.1.x GIT ID: f9074f2dffa3b91933e7f6fd266770c917ee2083.
6.2.x GIT ID: 594838800be4d2170a0276bb2946cda575aad8c6.

Samuel KongMarch 7, 2012 at 8:10 PM
It's not a Tomcat version issue. It should be related to changes made to Liferay.
But for reference, I'm using Tomcat 6.0.29
This worked as of master/6167914e3827602795da492ded14c2501ce9f23c
I'm attaching my portal-ext.properties. I'm pretty sure you'll also need to set some of these properties to get it to work. (Sorry about not including this last time)

Jonathan PotterMarch 7, 2012 at 8:53 AM
Are you sure this used to work? I've tested this with tomcat 7.0.25, 7.0.26, and 6.0.35 and it doesn't work with any of them. All deploy-fast does is to copy the files over, so you can do the same thing by modifying the files in <tomcat>/webapps/ROOT/...
It seems like the only way this could be our fault is if we've configured tomcat incorrectly. But it feels like this is tomcat's fault. It kind of makes sense that this would happen, since JSPF files aren't compiled on their own, there would be no way for tomcat to know if the file has changed. It can check JSP files for changes by checking if the .class file for the compiled JSP is older than the JSP file itself. But since there's no .class file for a JSPF (which is bundled into the JSP's class file), the only way to have it update is when the JSP changes.
Details
Assignee
SE SupportSE SupportReporter
Samuel KongSamuel Kong(Deactivated)Labels
Branch Version/s
6.1.xBackported to Branch
CommittedCaused by
Other bug fixGit Pull Request
Components
Fix versions
Affects versions
Priority
Medium
Details
Details
Assignee

Reporter

Labels
Branch Version/s
Backported to Branch
Caused by
Git Pull Request
Components
Fix versions
Affects versions
Priority
Zendesk Support
Linked Tickets
Zendesk Support
Linked Tickets
Zendesk Support

Example:
Documents and Media portlet to a page
Add a few images
Add the Media Gallery portlet
Make a change to /image_gallery_display/view_images.jspf
From /portal-web perform an
ant deploy-fast
Reload the page
Notice that the changes do not appear. (This use to work)
Make a change to /image_gallery_display/view.jsp
From /portal-web perform an
ant deploy-fast
Reload the page
Now both changes will appear.