ServiceBuilder in plugins SDK generates ServiceSoap with wrong return types for generic entity types

Description

When using plugins SDK, if a List<ModelEntity> is returned from a ServiceImpl method, the ServiceSoap class that is generated by ServiceBuilder has a return type of ModelEntity[] (incorrect) instead of ModelEntitySoap[] (correct).

This results in anything relying on ModelEntitySoap return values (such as the build-wsdd target) to fail.

Activity

Show:

Mathieu Hicauber March 26, 2013 at 1:56 AM

Thanks a lot ! Got my Service builder working now, no more editing generated java files

Minhchau Dang March 25, 2013 at 2:29 PM

The 6.0.x and 6.1.x repositories used for backporting fixes are not accessible to the general public. However, you can retrieve the changes as they appear in trunk using the following command:

git log --grep

Based on the results of that command, the fix requires the following changes (the second commit hash, which corresponds to the final source formatting, is listed as the 'committed on' in the above comments):

https://github.com/liferay/liferay-portal/commit/9fd084f6e02a4577229b5bf511ef5e58cb3bc7b9
https://github.com/liferay/liferay-portal/commit/3eb049dc835b18e24b9807a4785b45a772a2ab59

Mathieu Hicauber March 25, 2013 at 7:46 AM

Hi,

I got to fix this issue in my bundle (6.0.5 CE). How can I get the fix ? I wasn't able to find thos git commits. Don't even know if I was looking on the right repo though.

Thank you.

Mat.

Michael Saechang February 13, 2012 at 3:01 PM

Committed on:
6.0.x GIT ID: 60ca66f34d8451d7271138134124a428663aa6ad.
6.1.x GIT ID: 3eb049dc835b18e24b9807a4785b45a772a2ab59.
6.2.x GIT ID: 3eb049dc835b18e24b9807a4785b45a772a2ab59.

Minhchau Dang February 1, 2012 at 5:11 PM

This is because when it is trying to find the entity from the generic type, it is unable to find it since it's using the fully qualified name instead of the shortened name that excludes the package path.

Fixed

Details

Assignee

Reporter

Branch Version/s

6.1.x
6.0.x

Backported to Branch

Committed

Git Pull Request

Components

Affects versions

Priority

Zendesk Support

Created February 1, 2012 at 5:01 PM
Updated June 24, 2023 at 3:49 PM
Resolved March 12, 2012 at 1:41 PM
Loading...